[HAP] File upload / Overwrite / Download issue

[timbo343]

Since more users have been using HAP since the COVID19 issue, some have been reporting that when they upload a file back to the network and re-download it, the file they have downloaded doesn't contain the changes so it's like there is a caching issue in the browser. The browser that is in question is Chrome but it works as it should if IE11 is used.

[timbo343]

Further tests show that Edge Chromium is also affected but Firefox is fine.

[3s-gtech]

Is it worth disabling caching for the site in IIS?

[timbo343]

would it be a case of following this guide > How to disable cache in IIS | Devin Baldwin but adding .aspx as that is what HAP is built on?

 

@nickbro - are you able to offer any help here?

[3s-gtech]

Yup, prevent all caching option. I don’t think HAP has too much other content to be too cache dependent, but keep an eye on performance.

[timbo343]

Will try tonight as i can imagine it will be in use all day today.

[timbo343]

Ok i've tried the caching option but rather than tell IIS to use .aspx i saw the EDIT FEATURE SETTINGS on the right under Output Cache

 

 

This hasn't made a difference to Chrome or Edge Chromium. There must be a deeper issue with these 2 browsers as it does seem coincidental that they are built on the same platform.

 

There is an announcement on the home page of the Home Access Plus home page informing users what browsers to use.

 

[3s-gtech]

I suspect that the bug is those browsers may ignore the server-side do not cache flag. Have you tested by disabling the browser cache client-side? Obviously not ideal but will help in debugging.

[timbo343]

Yeap tried that too in Chrome and the issue still remains.

[3s-gtech]

How frustrating. That’s a lot of users affected, as Firefox’s market share isn’t that high (though Safari will be a big percentage). I wonder whether there’s a possible code change in the site to force a refresh - depends on your prowess in ASPX on that one.

[timbo343]

How frustrating. That’s a lot of users affected, as Firefox’s market share isn’t that high (though Safari will be a big percentage). I wonder whether there’s a possible code change in the site to force a refresh - depends on your prowess in ASPX on that one.

 

Errr, not a chance on that one.

[nickbro]

Hi all, it'll be a caching issue, that will be baked into the code I think.

 

Lets see if we can hack something into the javascript...

 

Line 798 of /myfiles/default.aspx

 

SelectedItems()[0].Data.Path.replace(/\\/g, "/") ---> (SelectedItems()[0].Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

 

Same on 814 + 1432

 

Line 1032 + 1047

 

item.Data.Path.replace(/\\/g, "/") --> (item.Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

[timbo343]

Hi all, it'll be a caching issue, that will be baked into the code I think.

 

Lets see if we can hack something into the javascript...

 

Line 798 of /myfiles/default.aspx

 

SelectedItems()[0].Data.Path.replace(/\\/g, "/") ---> (SelectedItems()[0].Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

 

Same on 814 + 1432

 

Line 1032 + 1047

 

item.Data.Path.replace(/\\/g, "/") --> (item.Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

 

Thanks Nick. Will try it over the weekend.

[nickbro]

I can't test anymore as I don't work in a place that uses HAP+ anymore.

[timbo343]

Hi all, it'll be a caching issue, that will be baked into the code I think.

 

Lets see if we can hack something into the javascript...

 

Line 798 of /myfiles/default.aspx

 

SelectedItems()[0].Data.Path.replace(/\\/g, "/") ---> (SelectedItems()[0].Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

 

Same on 814 + 1432

 

Line 1032 + 1047

 

item.Data.Path.replace(/\\/g, "/") --> (item.Data.Path.replace(/\\/g, "/") + '?' + Math.Random())

 

 

@nickbro Before editing i wanted to check with you that the line numbers married up - I don't have a line 1432.

 

Please check the images to see if they are correct

 

 

 

[nickbro]

Search for the original and replace

Should be near a download warning

[timbo343]

Ok, i've done a search and found the following - a few more than just on 3 lines.

 

SelectedItems()[0].Data.Path.replace:

 

Line 170

 

Line 710

 

Line 736

 

Line 774

 

Line 807

 

Line 830

 

 

item.Data.Path.replace

 

Line 870

 

Line 871

[nickbro]

870 should be it

[timbo343]

870 should be it

 

Thanks, so

 

OLD:

if (item.Data.Type != 'Directory') window.open((item.Data.Path.match(/\.\./i) ? item.Data.Path.replace(/\\/g, "/") : '#' + item.Data.Path));

 

NEW:

if (item.Data.Type != 'Directory') window.open((item.Data.Path.match(/\.\./i) ? [b](item.Data.Path.replace(/\\/g, "/") + '?' + Math.Random())[/b] : '#' + item.Data.Path));

 

 

What about the other one i need to change?

[timbo343]

Thanks, so

 

OLD:

if (item.Data.Type != 'Directory') window.open((item.Data.Path.match(/\.\./i) ? item.Data.Path.replace(/\\/g, "/") : '#' + item.Data.Path));

 

NEW:

if (item.Data.Type != 'Directory') window.open((item.Data.Path.match(/\.\./i) ? [b](item.Data.Path.replace(/\\/g, "/") + '?' + Math.Random())[/b] : '#' + item.Data.Path));

 

 

What about the other one i need to change?

 

@nickbro editing only line 870 didn't work - in fact it made the site not render correctly.

[nickbro]

Is it giving any errors?

[timbo343]

Is it giving any errors?

 

@nickbro

 

No - it shows the following:

 

 

I edited line as instructed to -