Ben-at-work

Hi everyone, I've been tasked with migrating file data from many servers to many other servers and have been given a powershelll script to use (as it can be code signed). The script basically inserts parameters into robocopy but I'm having trouble with the directories, they are listed in Powershell but when I look at the robocopy log the directories are changed to c: (source) and c: (destination), not sure what I'm missing! Set-StrictMode -Version 2.0 $VerbosePreference = "SilentlyContinue" # Set to SilentlyContinue to surpress write-verbose messages $smtp = “mail server” $to = “email” $from = “email” $ScriptName = $MyInvocation.MyCommand.Name $subject = “Subject” $logtime = Get-Date -Format "yyyyMMddhhmm" $attachments = “Logs” + $logtime + ".log" $emailbody = " $($scriptname)running from $($PSScriptRoot) by $($env:username) on $($env:computername) " + ` " Attached log file " + ` “Please view" # # Directories to mirror # $directories = @( (“\\server\share\source”, "\\server\share\destination”), ` ("\\server2\share\source", "\\server2\share\destination") ` ) $logging = "/LOG:" + $attachments $notify = 0 # foreach($directory in $directories) { Write-Verbose "$($directory[0])" Robocopy $directory[0] $directory[1] /MIR /R:2 /W:5 /COPYALL /DCOPY:T /ZB $logging ` /XF "~$*" ".vss_command" "Thumbs.db" ".DS_Store" "DS_Store" "*.tmp" ` /XD "$directory[0]\Experiential\.TemporaryItems""$directory[1]\.TemporaryItems" "$directory[1]\~snapshot" If ( $LASTEXITCODE -gt 1 ) { $notify = 1 } $logging = "/LOG+:" + $attachments } If ( $notify ) { Send-MailMessage -To $to -from $from -Subject $subject -Body $emailbody -bodyashtml -SmtpServer $smtp -Attachments $attachments Write-verbose "Email sent" }

Hi, We host one website internally (for some reason, all others are external) that is currently down. When I try to connect to the web admin portal I get the following: Failed to write to /etc/webmin/module.infos.cache : No space left on device Looking at the console it would appear the root partition is full, the problem is I have no idea how to free up space. I don't want to delete anything that is required so staying away from that. I did increase the disk size in ESX but can't find a simple way to increase the partition via cmd line. Can anyone help!

No worries, totally understand!

Hi Simon, Did you have any luck with this?

Haha, yeah a bit worrying! Thank you!

(function($) { // Disables selection. $.fn.disableSelection_dropotron = function() { return $(this).css('user-select', 'none').css('-khtml-user-select', 'none').css('-moz-user-select', 'none').css('-o-user-select', 'none').css('-webkit-user-select', 'none'); } // Dropotron prototype method. $.fn.dropotron = function(options) { if (this.length == 0) return $(this); if (this.length > 1) for (var i=0; i < this.length; i++) $(this[i]).dropotron(options); return $.dropotron($.extend({ selectorParent: $(this) }, options)); } // Dropotron method. $.dropotron = function(options) { // Settings. var settings = $.extend({ // Parent jQuery object. selectorParent: null, // Base Z-Index. baseZIndex: 1000, // Menu class (assigned to every </pre><ul>). menuClass: 'dropotron', // Expansion mode ("hover" or "click"). expandMode: 'hover', // Hover delay (in ms). hoverDelay: 150, // Hide delay (in ms; 0 disables). hideDelay: 250, // Opener class. openerClass: 'opener', // Active opener class. openerActiveClass: 'active', // Submenu class prefix. submenuClassPrefix: 'level-', // Menu mode ("instant", "fade", "slide", "zoom"). mode: 'fade', // Menu speed ("fast", "slow", or ms). speed: 'fast', // Easing mode ("swing", "linear"). easing: 'swing', // Alignment ("left", "center", "right"). alignment: 'left', // Submenu offset X. offsetX: 0, // Submenu offset Y. offsetY: 0, // Global offset Y. globalOffsetY: 0, // IE Offset X. IEOffsetX: 0, // IE Offset Y. IEOffsetY: 0, // If true and mode = "fade", prevents top-level opener fade. noOpenerFade: true, // Detach second level menus (prevents parent style bleed). detach: true, // If true and detach = true, leave original menu intact. cloneOnDetach: true }, options); // Vars. var $top = settings.selectorParent, $menus = $top.find('ul'), $body = $('body'), $bodyhtml = $('body,html'), $window = $(window); var isLocked = false, hoverTimeoutId = null, hideTimeoutId = null; // Main. // Top. $top .on('doCollapseAll', function() { $menus.trigger('doCollapse'); }); // Top level menus. $menus.each(function() { var $menu = $(this), $opener = $menu.parent(); // If a hideDelay is set, set up the event. if (settings.hideDelay > 0) $menu.add($opener) .on('mouseleave', function(e) { window.clearTimeout(hideTimeoutId); hideTimeoutId = window.setTimeout(function() { $menu.trigger('doCollapse'); }, settings.hideDelay); }); // Menu. $menu .disableSelection_dropotron() .hide() .addClass(settings.menuClass) .css('position', 'absolute') .on('mouseenter', function(e) { window.clearTimeout(hideTimeoutId); }) .on('doExpand', function() { // Already visible? Bail out. if ($menu.is(':visible')) return false; // Reset our "hide" timeout. window.clearTimeout(hideTimeoutId); // Collapse everything but this menu. $menus.each(function() { var $this = $(this); if (!$.contains($this.get(0), $opener.get(0))) $this.trigger('doCollapse'); }); // Vars. var oo = $opener.offset(), op = $opener.position(), opp = $opener.parent().position(), ow = $opener.outerWidth(), mw = $menu.outerWidth(), isTL = ($menu.css('z-index') == settings.baseZIndex); var x, c, left, top; // If this is a top level menu ... if (isTL) { // If detach is enabled, use .position() if (!settings.detach) x = op; // Otherwise, use .offset() else x = oo; top = x.top + $opener.outerHeight() + settings.globalOffsetY; c = settings.alignment; // Remove alignment classes. $menu .removeClass('left') .removeClass('right') .removeClass('center'); // Figure out alignment and position. switch (settings.alignment) { case 'right': left = x.left - mw + ow; if (left < 0) { left = x.left; c = 'left'; } break; case 'center': left = x.left - Math.floor((mw - ow) / 2); if (left < 0) { left = x.left; c = 'left'; } else if (left + mw > $window.width()) { left = x.left - mw + ow; c = 'right'; } break; case 'left': default: left = x.left; if (left + mw > $window.width()) { left = x.left - mw + ow; c = 'right'; } break; } // Add alignment class. $opener.find( 'a' ).blur(); // Take focus off the opening link $menu .addClass(c) .find( 'li' ) .first() .find( 'a' ) .focus(); // After adding classes, give focus to the first anchor tag in the submenu } // Otherwise, we're dealing with a submenu. else { // If the opener position isn't static ... if ($opener.css('position') == 'relative' || $opener.css('position') == 'absolute') { top = settings.offsetY; left = (-1 * op.left); } else { top = op.top + settings.offsetY; left = 0; } // Figure out position (based on alignment). switch (settings.alignment) { case 'right': left += (-1 * $opener.parent().outerWidth()) + settings.offsetX; break; case 'center': case 'left': default: left += $opener.parent().outerWidth() + settings.offsetX; break; } } // Legacy IE? Apply IE-specific offsets. if (navigator.userAgent.match(/MSIE ([0-9]+)\./) && RegExp.$1 < 8) { left += settings.IEOffsetX; top += settings.IEOffsetY; } // Position and show the menu. $menu .css('left', left + 'px') .css('top', top + 'px') .css('opacity', '0.01') .show(); // Kludge! var tmp = false; // Non-static position fix. if ($opener.css('position') == 'relative' || $opener.css('position') == 'absolute') left = (-1 * op.left); else left = 0; if ($menu.offset().left < 0) { left += $opener.parent().outerWidth() - settings.offsetX; tmp = true; } else if ($menu.offset().left + mw > $window.width()) { left += (-1 * $opener.parent().outerWidth()) - settings.offsetX; tmp = true; } if (tmp) $menu .css('left', left + 'px'); $menu .hide() .css('opacity', '1'); // Figure out animation mode. switch (settings.mode) { case 'zoom': isLocked = true; $opener.addClass(settings.openerActiveClass); $menu.animate({ width: 'toggle', height: 'toggle' }, settings.speed, settings.easing, function() { isLocked = false; }); break; case 'slide': isLocked = true; $opener.addClass(settings.openerActiveClass); $menu.animate({ height: 'toggle' }, settings.speed, settings.easing, function() { isLocked = false; }); break; case 'fade': isLocked = true; if (isTL && !settings.noOpenerFade) { var tmp; if (settings.speed == 'slow') tmp = 80; else if (settings.speed == 'fast') tmp = 40; else tmp = Math.floor(settings.speed / 2); $opener.fadeTo(tmp, 0.01, function() { $opener.addClass(settings.openerActiveClass); $opener.fadeTo(settings.speed, 1); $menu.fadeIn(settings.speed, function() { isLocked = false; }); }); } else { $opener.addClass(settings.openerActiveClass); $opener.fadeTo(settings.speed, 1); $menu.fadeIn(settings.speed, function() { isLocked = false; }); } break; case 'instant': default: $opener.addClass(settings.openerActiveClass); $menu.show(); break; } return false; }) .on('doCollapse', function() { // Not visible? Bail out. if (!$menu.is(':visible')) return false; // Collapse the menu. $menu.hide(); $opener.removeClass(settings.openerActiveClass); $menu.find('.' + settings.openerActiveClass).removeClass(settings.openerActiveClass); $menu.find('ul').hide(); return false; }) .on('doToggle', function(e) { if ($menu.is(':visible')) $menu.trigger('doCollapse'); else $menu.trigger('doExpand'); return false; }); // Menu's opener. $opener .disableSelection_dropotron() .addClass('opener') .css('cursor', 'pointer') .on('click touchend', function(e) { // Locked? Bail. if (isLocked) return; // Toggle menu. e.preventDefault(); e.stopPropagation(); $menu.trigger('doToggle'); }); // If expandMode is "hover", set up the event. if (settings.expandMode == 'hover') $opener.hover(function(e) { if (isLocked) return; hoverTimeoutId = window.setTimeout(function() { $menu.trigger('doExpand'); }, settings.hoverDelay); }, function (e) { window.clearTimeout(hoverTimeoutId); }); }); // All links. $menus.find('a') .css('display', 'block') .on('click touchend', function(e) { // Locked? Bail. if (isLocked) return; // No href? Prevent default. if ($(this).attr('href').length < 1) e.preventDefault(); }); // All list items. $top.find('li') .css('white-space', 'nowrap') .each(function() { var $this = $(this), $a = $this.children('a'), $ul = $this.children('ul'), href = $a.attr('href'); // If href is blank ("") or a hash (#), prevent the link from doing anything. $a.on('click touchend', function(e) { if (href.length == 0 || href == '#') e.preventDefault(); else e.stopPropagation(); }); // If there is a link but no unordered list ... if ($a.length > 0 && $ul.length == 0) $this.on('click touchend', function(e) { if (isLocked) return; $top.trigger('doCollapseAll'); e.stopPropagation(); }); }); // Top level list items. $top.children('li').each(function() { var $opener = $(this), $menu = $opener.children('ul'), c; if ($menu.length > 0) { // If we're using detach ... if (settings.detach) { // If we're cloning on detach ... if (settings.cloneOnDetach) { // Make a copy of the menu. c = $menu.clone(); // Leave it behind c .attr('class', '') .hide() .appendTo($menu.parent()); } // Detach the menu and move it to the end of the element. $menu .detach() .appendTo($body); } // Step through menus, assigning z-indexes and submenu class prefixes as necessary. for(var z = settings.baseZIndex, i = 1, y = $menu; y.length > 0; i++) { y.css('z-index', z++); if (settings.submenuClassPrefix) y.addClass(settings.submenuClassPrefix + (z - 1 - settings.baseZIndex)); y = y.find('> li > ul'); } } }); // Window. $window .on('', function() { $top.trigger('doCollapseAll'); }) .on('keypress', function(e) { // Collapse all menus if the user hits escape. if (!isLocked && e.keyCode == 27) { e.preventDefault(); $top.trigger('doCollapseAll'); } }); // Body. $bodyhtml .on('click touchend', function() { if (!isLocked) $top.trigger('doCollapseAll'); }); }; })(jQuery)

Yeah, it was working absolutely perfectly until this morning until we noticed it stopped working on machines running version 50.0.2661.86. Nothing has changed in the code (I haven't touched it anyway) but have pasted below anyway. I can't thank you enough for looking at this. The JS will be in a separate post due to the length. Curriculum Art GCSE Media Studies Humanities & Social Sciences Information Information Home Admissions Behaviour For Learning

Hi Simon, Sorry to drag this back up, it appears this doesn't work on the latest version of Chrome (Windows or OS X) or Firefox (both OSs). Nearly had a heart attack when we started to deploy the updated versions this morning. Is there anything you can think of that I could do? Thanks, Ben

After you have made a change (in System Preferences or via terminal or whatever) is that change reflected in /etc/ntp.conf? We had this same problem since coming back, even though they already had the correct ntp server specified in system preferences I sent out the following via remote desktop... systemsetup -setnetworktimeserver ntpserverip ...to force a rewrite of /etc/ntp.conf After a restart the correct time was displayed again and users could log back in. If the above doesn't work try removing ntp.conf, restarting, then changing the ntp settings.

Still doing on Windows Firefox, fine everywhere else. Odd, but shouldn't be a deal breaker! Thanks for all you help, it really is appreciated.

Hi Simon, Thank you so much for this, I really appreciate the time you took - you've got me out of a hole! Oddly it doesn't work in Firefox on Windows (only), but I'll dig into that later. If someone has JS disabled, the menu won't appear is there anything simple I could to counteract this? Thanks again.

/* jquery.dropotron.js v1.4.3 | (c) n33 | n33.co | MIT licensed */ (function($) { // Disables selection. $.fn.disableSelection_dropotron = function() { return $(this).css('user-select', 'none').css('-khtml-user-select', 'none').css('-moz-user-select', 'none').css('-o-user-select', 'none').css('-webkit-user-select', 'none'); } // Dropotron prototype method. $.fn.dropotron = function(options) { if (this.length == 0) return $(this); if (this.length > 1) for (var i=0; i < this.length; i++) $(this[i]).dropotron(options); return $.dropotron($.extend({ selectorParent: $(this) }, options)); } // Dropotron method. $.dropotron = function(options) { // Settings. var settings = $.extend({ // Parent jQuery object. selectorParent: null, // Base Z-Index. baseZIndex: 1000, // Menu class (assigned to every </pre><ul>). menuClass: 'dropotron', // Expansion mode ("hover" or "click"). expandMode: 'hover', // Hover delay (in ms). hoverDelay: 150, // Hide delay (in ms; 0 disables). hideDelay: 250, // Opener class. openerClass: 'opener', // Active opener class. openerActiveClass: 'active', // Submenu class prefix. submenuClassPrefix: 'level-', // Menu mode ("instant", "fade", "slide", "zoom"). mode: 'fade', // Menu speed ("fast", "slow", or ms). speed: 'fast', // Easing mode ("swing", "linear"). easing: 'swing', // Alignment ("left", "center", "right"). alignment: 'left', // Submenu offset X. offsetX: 0, // Submenu offset Y. offsetY: 0, // Global offset Y. globalOffsetY: 0, // IE Offset X. IEOffsetX: 0, // IE Offset Y. IEOffsetY: 0, // If true and mode = "fade", prevents top-level opener fade. noOpenerFade: true, // Detach second level menus (prevents parent style bleed). detach: true, // If true and detach = true, leave original menu intact. cloneOnDetach: true }, options); // Vars. var $top = settings.selectorParent, $menus = $top.find('ul'), $body = $('body'), $bodyhtml = $('body,html'), $window = $(window); var isLocked = false, hoverTimeoutId = null, hideTimeoutId = null; // Main. // Top. $top .on('doCollapseAll', function() { $menus.trigger('doCollapse'); }); // Top level menus. $menus.each(function() { var $menu = $(this), $opener = $menu.parent(); // If a hideDelay is set, set up the event. if (settings.hideDelay > 0) $menu.add($opener) .on('mouseleave', function(e) { window.clearTimeout(hideTimeoutId); hideTimeoutId = window.setTimeout(function() { $menu.trigger('doCollapse'); }, settings.hideDelay); }); // Menu. $menu .disableSelection_dropotron() .hide() .addClass(settings.menuClass) .css('position', 'absolute') .on('mouseenter', function(e) { window.clearTimeout(hideTimeoutId); }) .on('doExpand', function() { // Already visible? Bail out. if ($menu.is(':visible')) return false; // Reset our "hide" timeout. window.clearTimeout(hideTimeoutId); // Collapse everything but this menu. $menus.each(function() { var $this = $(this); if (!$.contains($this.get(0), $opener.get(0))) $this.trigger('doCollapse'); }); // Vars. var oo = $opener.offset(), op = $opener.position(), opp = $opener.parent().position(), ow = $opener.outerWidth(), mw = $menu.outerWidth(), isTL = ($menu.css('z-index') == settings.baseZIndex); var x, c, left, top; // If this is a top level menu ... if (isTL) { // If detach is enabled, use .position() if (!settings.detach) x = op; // Otherwise, use .offset() else x = oo; top = x.top + $opener.outerHeight() + settings.globalOffsetY; c = settings.alignment; // Remove alignment classes. $menu .removeClass('left') .removeClass('right') .removeClass('center'); // Figure out alignment and position. switch (settings.alignment) { case 'right': left = x.left - mw + ow; if (left < 0) { left = x.left; c = 'left'; } break; case 'center': left = x.left - Math.floor((mw - ow) / 2); if (left < 0) { left = x.left; c = 'left'; } else if (left + mw > $window.width()) { left = x.left - mw + ow; c = 'right'; } break; case 'left': default: left = x.left; if (left + mw > $window.width()) { left = x.left - mw + ow; c = 'right'; } break; } // Add alignment class. $menu.addClass(c); } // Otherwise, we're dealing with a submenu. else { // If the opener position isn't static ... if ($opener.css('position') == 'relative' || $opener.css('position') == 'absolute') { top = settings.offsetY; left = (-1 * op.left); } else { top = op.top + settings.offsetY; left = 0; } // Figure out position (based on alignment). switch (settings.alignment) { case 'right': left += (-1 * $opener.parent().outerWidth()) + settings.offsetX; break; case 'center': case 'left': default: left += $opener.parent().outerWidth() + settings.offsetX; break; } } // Legacy IE? Apply IE-specific offsets. if (navigator.userAgent.match(/MSIE ([0-9]+)\./) && RegExp.$1 < 8) { left += settings.IEOffsetX; top += settings.IEOffsetY; } // Position and show the menu. $menu .css('left', left + 'px') .css('top', top + 'px') .css('opacity', '0.01') .show(); // Kludge! var tmp = false; // Non-static position fix. if ($opener.css('position') == 'relative' || $opener.css('position') == 'absolute') left = (-1 * op.left); else left = 0; if ($menu.offset().left < 0) { left += $opener.parent().outerWidth() - settings.offsetX; tmp = true; } else if ($menu.offset().left + mw > $window.width()) { left += (-1 * $opener.parent().outerWidth()) - settings.offsetX; tmp = true; } if (tmp) $menu .css('left', left + 'px'); $menu .hide() .css('opacity', '1'); // Figure out animation mode. switch (settings.mode) { case 'zoom': isLocked = true; $opener.addClass(settings.openerActiveClass); $menu.animate({ width: 'toggle', height: 'toggle' }, settings.speed, settings.easing, function() { isLocked = false; }); break; case 'slide': isLocked = true; $opener.addClass(settings.openerActiveClass); $menu.animate({ height: 'toggle' }, settings.speed, settings.easing, function() { isLocked = false; }); break; case 'fade': isLocked = true; if (isTL && !settings.noOpenerFade) { var tmp; if (settings.speed == 'slow') tmp = 80; else if (settings.speed == 'fast') tmp = 40; else tmp = Math.floor(settings.speed / 2); $opener.fadeTo(tmp, 0.01, function() { $opener.addClass(settings.openerActiveClass); $opener.fadeTo(settings.speed, 1); $menu.fadeIn(settings.speed, function() { isLocked = false; }); }); } else { $opener.addClass(settings.openerActiveClass); $opener.fadeTo(settings.speed, 1); $menu.fadeIn(settings.speed, function() { isLocked = false; }); } break; case 'instant': default: $opener.addClass(settings.openerActiveClass); $menu.show(); break; } return false; }) .on('doCollapse', function() { // Not visible? Bail out. if (!$menu.is(':visible')) return false; // Collapse the menu. $menu.hide(); $opener.removeClass(settings.openerActiveClass); $menu.find('.' + settings.openerActiveClass).removeClass(settings.openerActiveClass); $menu.find('ul').hide(); return false; }) .on('doToggle', function(e) { if ($menu.is(':visible')) $menu.trigger('doCollapse'); else $menu.trigger('doExpand'); return false; }); // Menu's opener. $opener .disableSelection_dropotron() .addClass('opener') .css('cursor', 'pointer') .on('click touchend', function(e) { // Locked? Bail. if (isLocked) return; // Toggle menu. e.preventDefault(); e.stopPropagation(); $menu.trigger('doToggle'); }); // If expandMode is "hover", set up the event. if (settings.expandMode == 'hover') $opener.hover(function(e) { if (isLocked) return; hoverTimeoutId = window.setTimeout(function() { $menu.trigger('doExpand'); }, settings.hoverDelay); }, function (e) { window.clearTimeout(hoverTimeoutId); }); }); // All links. $menus.find('a') .css('display', 'block') .on('click touchend', function(e) { // Locked? Bail. if (isLocked) return; // No href? Prevent default. if ($(this).attr('href').length < 1) e.preventDefault(); }); // All list items. $top.find('li') .css('white-space', 'nowrap') .each(function() { var $this = $(this), $a = $this.children('a'), $ul = $this.children('ul'), href = $a.attr('href'); // If href is blank ("") or a hash (#), prevent the link from doing anything. $a.on('click touchend', function(e) { if (href.length == 0 || href == '#') e.preventDefault(); else e.stopPropagation(); }); // If there is a link but no unordered list ... if ($a.length > 0 && $ul.length == 0) $this.on('click touchend', function(e) { if (isLocked) return; $top.trigger('doCollapseAll'); e.stopPropagation(); }); }); // Top level list items. $top.children('li').each(function() { var $opener = $(this), $menu = $opener.children('ul'), c; if ($menu.length > 0) { // If we're using detach ... if (settings.detach) { // If we're cloning on detach ... if (settings.cloneOnDetach) { // Make a copy of the menu. c = $menu.clone(); // Leave it behind c .attr('class', '') .hide() .appendTo($menu.parent()); } // Detach the menu and move it to the end of the element. $menu .detach() .appendTo($body); } // Step through menus, assigning z-indexes and submenu class prefixes as necessary. for(var z = settings.baseZIndex, i = 1, y = $menu; y.length > 0; i++) { y.css('z-index', z++); if (settings.submenuClassPrefix) y.addClass(settings.submenuClassPrefix + (z - 1 - settings.baseZIndex)); y = y.find('> li > ul'); } } }); // Window. $window .on('', function() { $top.trigger('doCollapseAll'); }) .on('keypress', function(e) { // Collapse all menus if the user hits escape. if (!isLocked && e.keyCode == 27) { e.preventDefault(); $top.trigger('doCollapseAll'); } }); // Body. $bodyhtml .on('click touchend', function() { if (!isLocked) $top.trigger('doCollapseAll'); }); }; })(jQuery)

Hi, really hope someone here can help or offer some guidance. I'm using dropotron to power the drop down menus (code will be on post below) on our new site which works fine. The problem I have is that's not very accessible for keyboard only users. Curriculum Art GCSE Media Studies Humanities & Social Sciences Information Information Home Admissions Behaviour For Learning For example, if a user hovers the mouse over Curriculum the submenu appears. On a mobile device touching Curriculum displays the sub menu. Tab-Enter will display the menu, but tabbing again will move to the next option at the top level, it will move to Information rather than Art on the submenu. Looking at Information which has a specified URL we get the following. Mouse hover displays the sub menu, touch and tab-enter take the user to the URL specified. What I'm desperate to achieve is the following behaviour: When a menu is hovered by a mouse, show the sub-menu. When a menu is clicked with a mouse, open the link (or do nothing, or close the menu - not too bothered!). The first time a menu is clicked by touch, show the sub menu. The second time a menu is clicked by touch, open the link (or do nothing, or close the menu - not too bothered!). Hitting Enter opens the link I'm in no way an expert (barely a beginner!) with JS so anything would be a help!

Beautiful, thank you!

Hi, I'm using this guide to create a modal that appears on our homepage, the idea being I'll only use it for important alerts (snow days etc). It works fine, the only issue I have is that the close button requires two clicks to close. Looking the code I think what the function is doing is trying to show the div with the first click then on the second is when it hides it. I am a complete newbie to JS so would appreciate some help in getting the modal to close after one click. function overlay() { el = document.getElementById("overlay"); el.style.visibility = (el.style.visibility == "visible") ? "hidden" : "visible"; } 13/01/2016, 07:17am - School is closed today due to severe weather. For more information please see our Facebook page. Close /* Alert */ #overlay { visibility: visible; position: fixed; left: 0px; top: 0px; width: 100%; height: 100%; text-align:center; z-index: 1000; background-image:url("images/alert.png"); } #overlay div { border-radius: 15px; width: 75%; height: 75%; margin: 100px auto; background-color: #1c1d26; border: 1px solid #ffcc00; padding: 10px 10px; text-align:center; }