Bookings - Advanced Permissions

TheScarfedOne · March 19, 2012

Hi Nick

Ive not upgraded to 7.10 yet - so apologies if youve fixed this already...

Im trying to use the Advanced Booking Rights to extend the booking window for some staff. Ive entered their username, and changed the setting so that is is 10 weeks in advance - but it isnt setting it (the dates show greyed out still). It soes seemt to set the max bookings per week successfully though.

Any ideas?

Stuart

TheScarfedOne · March 22, 2012

And another discrepancy surrounding rights on bookings...

Ive now upgraded to v7.10... and these are the issues I've spotted:

1. Advanced Booking Rights - Max number of bookings per weeks is applied, but number of weeks in advance isn't

2. Additional Admins of a Room/Resource get the "over-ride" option on bookings, but they cannot book on behalf of someone else.

Upgrade otherwise works nicely Nick. Great work. Still got that other bug with MyFiles not displaying and throwing that error as per other thread....

TheScarfedOne · March 22, 2012

And a bit more digging on it. If I remove the users from the "Additional admins" on the Room/Resource - it doesn't look like it is reading the group membership of the AD group added on the HAP Config screen under Bookings > Administrators.

Any troubleshooting ideas as this one is a major PITA!

Stuart

nickbro · March 25, 2012

Ok, I think I've fixed both of these bugs, any chance you can test the attached dll.

The 1st, I've added a loop that checks each week, and then adds any addition days.

The 2nd, was only looking for usernames, not AD Groups, it now does both

TheScarfedOne · March 26, 2012

Hi Nick. Ok - Ive replaced the DLL and restarted IIS. Sadly - no change.

The user is listed as an additional admin on the HAP Config page, but doesnt get the ability to book on behalf of someone else. They can remove/override others though - so some parts of the additional admin are working. Ive given the user Advanced Permissions from the Bookings Control panel - and the number of bookings for the week sets correctly now, but the number of days in advance doesnt.

nickbro · March 26, 2012

ok, very odd, will keep looking into this

nickbro · March 26, 2012

very odd, the Advanced Rights work for me (for some reason it's -1 week from what is actually set (though that could because it's Monday))

The admin rights also works, where the user can book as another user

TheScarfedOne · March 26, 2012

Ok - Ive found one sort of fix. The username needed to be entered as DOMAIN\Username in the Advanced Permissions. Setting as a Room Admin (via HAP config generated the ability to remove and override booking; adding the user to the group defined at the top of the booking section gave the "As another user" option.

So, Ive used a combo approach on that - and it is working ok now.

Ive got a feature request on bookings - which I will put in the right area too; but as its related to bookings - I'll stick it here too!

The ability to book a whole day rather than go for each session would be great. Kind of an option to copy to remainder of the day or something like that.

Hope you can do it...

Stuart

nickbro · March 26, 2012

You shouldn't have to use domain\ at all, unless there is a config issue. Are you using Forms or Windows Auth?

TheScarfedOne · March 27, 2012

Im using Windows Auth - as Im one of your awkward ISA/TMG users. I will try taking it out just to confirm, but thats the change that seemed to make it work. What do you think of the feature request?

Great work as always, thanks

Stuart

nickbro · March 27, 2012

Ah, that could be why, it may need domain\username in that case

TheScarfedOne · April 3, 2012

Hmmm.... there is still a discrepancy here somewhere! Im trying to find it...

Ok... heres the scenario...

In the HAP Config screen - Booking System - Administrators group selected as Staff-BookingsAdmin (thats our AD group that contains the higher level users)

This correctly gives them the "book as someone else" option. It does not however over-ride the max days (cant tell if over-rides max bookings - but the info bar doesnt contain the entry "You have x bookings remaining this week").

So, go to Advanced permissions to add this as DOMAIN\username, which works - so long as its not during a holiday (but it is now - which throws a lovely error... shown at the end).

Can you set it so that being in the extra admin group correctly handles max bookings and bookings in advance (no limit) as it does on Domain Admins; or can we bug fix that new dll?

Oh... and I went back to that dll, which doesnt produce the error below - but then we are back to the max bookings limit again!

The added or subtracted value results in an un-representable DateTime.

Parameter name: value

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime.

Parameter name: value

Source Error:

Line 86:

Line 87: var curdate, curres, curles;

Line 88: var user = { <%=JSUser %> };

Line 89: var resources = <%=JSResources %>;

Line 90: var availbookings = [ 0, 0 ];

Source File: d:\Program Files\HAP7\BookingSystem\Default.aspx Line: 88

Stack Trace:

[ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime.

Parameter name: value]

System.DateTime.AddTicks(Int64 value) +9624435

System.DateTime.Add(Double value, Int32 scale) +136

HAP.Web.BookingSystem._new.get_JSUser() +3055

ASP.bookingsystem_default_aspx.__Render__control13(HtmlTextWriter __w, Control parameterContainer) in d:\Program Files\HAP7\BookingSystem\Default.aspx:88

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +109

System.Web.UI.Control.RenderChildren(HtmlTextWriter writer) +8

System.Web.UI.HtmlControls.HtmlContainerControl.Render(HtmlTextWriter writer) +31

HAP.Web.Controls.CompressJS.Render(HtmlTextWriter writer) +4

System.Web.UI.Control.RenderControlInternal(HtmlTextWriter writer, ControlAdapter adapter) +27

System.Web.UI.Control.RenderControl(HtmlTextWriter writer, ControlAdapter adapter) +100

System.Web.UI.Control.RenderControl(HtmlTextWriter writer) +25

ASP.bookingsystem_default_aspx.__Render__control3(HtmlTextWriter __w, Control parameterContainer) in d:\Program Files\HAP7\BookingSystem\Default.aspx:82

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +109

System.Web.UI.Control.RenderChildren(HtmlTextWriter writer) +8

System.Web.UI.Control.Render(HtmlTextWriter writer) +10

System.Web.UI.Control.RenderControlInternal(HtmlTextWriter writer, ControlAdapter adapter) +27

System.Web.UI.Control.RenderControl(HtmlTextWriter writer, ControlAdapter adapter) +100

System.Web.UI.Control.RenderControl(HtmlTextWriter writer) +25

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +208

System.Web.UI.HtmlControls.HtmlForm.RenderChildren(HtmlTextWriter writer) +173

System.Web.UI.HtmlControls.HtmlContainerControl.Render(HtmlTextWriter writer) +31

System.Web.UI.HtmlControls.HtmlForm.Render(HtmlTextWriter output) +53

System.Web.UI.Control.RenderControlInternal(HtmlTextWriter writer, ControlAdapter adapter) +27

System.Web.UI.Control.RenderControl(HtmlTextWriter writer, ControlAdapter adapter) +100

System.Web.UI.HtmlControls.HtmlForm.RenderControl(HtmlTextWriter writer) +40

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +208

System.Web.UI.Control.RenderChildren(HtmlTextWriter writer) +8

System.Web.UI.Control.Render(HtmlTextWriter writer) +10

System.Web.UI.Control.RenderControlInternal(HtmlTextWriter writer, ControlAdapter adapter) +27

System.Web.UI.Control.RenderControl(HtmlTextWriter writer, ControlAdapter adapter) +100

System.Web.UI.Control.RenderControl(HtmlTextWriter writer) +25

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +208

System.Web.UI.Control.RenderChildren(HtmlTextWriter writer) +8

System.Web.UI.Page.Render(HtmlTextWriter writer) +29

System.Web.UI.Control.RenderControlInternal(HtmlTextWriter writer, ControlAdapter adapter) +27

System.Web.UI.Control.RenderControl(HtmlTextWriter writer, ControlAdapter adapter) +100

System.Web.UI.Control.RenderControl(HtmlTextWriter writer) +25

System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +3060

--------------------------------------------------------------------------------

Version Information: Microsoft .NET Framework Version:4.0.30319; ASP.NET Version:4.0.30319.272

TheScarfedOne · April 3, 2012

Extrra debug information - so long as the information i put in the for max weeks in advance is a single digit (ie up to 9) - then it works. Go to 10 - then the error appears.

nickbro · April 6, 2012

Just checked a code release into codeplex which may fix some of the issues you've addressed here, the date not moving to the next free day during a holiday was starting to annoy me, found out why it wasn't working, it is now.

Can you try the attached dlls, they should enable correct line references for me to debug.

TheScarfedOne · April 13, 2012

Ok... going to be a few separate posts here...

Scenario 1: User has ABR's set - below 10 and over 10 days in advance (and is not a Booking Admin) results in the following

Server Error in '/HAP7' Application.

--------------------------------------------------------------------------------

The added or subtracted value results in an un-representable DateTime.

Parameter name: value

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime.

Parameter name: value

Source Error:

Line 86:

Line 87: var curdate, curres, curles;

Line 88: var user = { <%=JSUser %> };

Line 89: var resources = <%=JSResources %>;

Line 90: var availbookings = [ 0, 0 ];

Source File: d:\Program Files\HAP7\BookingSystem\Default.aspx Line: 88

[ArgumentOutOfRangeException: The added or subtracted value results in an un-representable DateTime.

Parameter name: value]

System.DateTime.AddTicks(Int64 value) +9624435

System.DateTime.Add(Double value, Int32 scale) +136

HAP.Web.BookingSystem._new.get_JSUser() in H:\Documents\Visual Studio 2010\Projects\CHS Extranet\HAP.Web\BookingSystem\Default.aspx.cs:174

ASP.bookingsystem_default_aspx.__Render__control13(HtmlTextWriter __w, Control parameterContainer) in d:\Program Files\HAP7\BookingSystem\Default.aspx:88

System.Web.UI.Control.RenderChildrenInternal(HtmlTextWriter writer, ICollection children) +109

System.Web.UI.Control.RenderChildren(HtmlTextWriter writer) +8

System.Web.UI.HtmlControls.HtmlContainerControl.Render(HtmlTextWriter writer) +31

HAP.Web.Controls.CompressJS.Render(HtmlTextWriter writer) in H:\Documents\Visual Studio 2010\Projects\CHS Extranet\HAP.Web\Controls\CompressJS.cs:29