Windows Thread, Logon script suddenly throwing up error in Technical; In your code you have repeated chunks of code regarding your DIMS ie Dim x As Integer or Dim strText ...
In your code you have repeated chunks of code regarding your DIMS ie Dim x As Integer or Dim strText and the same for the creation of objects
Code:
-> Set objNetwork = CreateObject("WScript.Network")
Set WSHShell = CreateObject("WScript.Shell")
-> Set WshNetwork = WScript.CreateObject("WScript.Network")-> Set oNetwork = CreateObject("WScript.Network")
Set clPrinters = WshNetwork.EnumPrinterConnections
You only need one and whenever you need to use it again you just change the coding below to refer to one so you could delete the 2nd and 3rd one and only use the first one or however you wanted to do it as you dont need to create the same object with different variable names
ie
Code:
Set WshNetwork = WScript.CreateObject("WScript.Network")
Wscript.Echo WshNetwork.Username
Are you able to post the few lines of code where you think its erroring out on ?
Also you have a disconnect sub - which you shouldn't need as when you are mapping the printers there is a for loop that removes all printers before it re adds them.
at the end of day its for testing...
not world order..
what's that comment all about ?
Just trying to tidy the code up so it makes more sense and not repeatdly re create the same objects with different variable names and the same for declaring of variables, its just not needed.
Also could create a sub to take the server name and share name as the rest of the code regarding adding of a printer is the same
You could try updating/reinstallling WSH on the affected machines, i've had a few times where it can become messed up. There should be a download on the MS site ... Type Windows Script Host in the search
OK, some progress. I spent about an hour looking at this with my secondary school technical support person. Turns out that the colour printer was a bit of a red herring - the current error points to line 138 or 148 depending on which of the scripts runs (logon or stafflogon). This line refers to the Y5Laser. The colour printer is being blocked because in one script it comes after the Y5Laser - in the other script it comes before.
Originally Posted by Cools
its just to check the connection to the printer..
as student.. some thing has changed even if you dont know what it is..
login in as admin is pointless as it's like having a master key to the school..
the script is to just test the connection as a student on a student GPO.. its saying it cant find it... i could say theres a dns error but not knowing what its set up like..
just try it for entertainment.. i have the same argument with virgin when things dont work.. and they say "Well everyone else is ok in the street" it does not help.
Yes, thanks for the test script. The colour printer mapped and pings fine. The Y5Laser pings, but doesn't map, even as domain admin. We've checked the share name is correct and checked permissions, and checked the IP address of the port.
I went and tested a random sample of other laptops that connect to Y5Laser. All are showing the same issue (although no one had logged it). We REMd out the Y5Laser lines in the script, and the scripting error went away. So there appears to be an issue with this particular printer and the curriculum laptops. Staff laptops, which aren't on the domain, print to it fine. Can do a test print direct from the server too. Ran out of time, but next test will be to run a test from a networked desktop in the IT Suite. I'm also going to double check the Y4Laser, as it is same make and model as Y5Laser. Both are HP 2200dn with JetDirect cards.
Working on a YR4 laptop and it is fine, with no scripting error and the Y4Laser set as default. BUT just been to deal with a problem in year 3 on a laptop, and when they logged in they were getting a scripting error. This laptop had just been brought to me because it had failed to log on to the network, and had come up with a local profile (no scripting error then). When logged on next time, it had picked up the network, but had a scripting error.
The laptop I am using shows a printer connection to a printer called Y4Laser, with the printer set to Ready. I am logged in as domain admin. If I double click the printer, I get the attached on screen.
I can't map to this printer from this laptop.
The laptops behind me, using the same wireless connection to the network, can map to the printer with no error messages. All of the laptops in this room with me are in the same AD group and they were all imaged from the same build. The laptops behind me are a random sample from year 4. None have the scripting error. So far, this year group seems to be the only one unaffected by the issues with these laser printers, unless I have been incredibly lucky with my random sample.
LinkBack URL
About LinkBacks
Reply With Quote
Originally Posted by Cools 
