[Javascript] Where did i miss something?

[mossj]

Whats wrong with this? (been staring at a screen to long most likely its something simple). It won't even run any of it and throws an error when called.

function session() {
if (document.getElementById("sessionType").value == "http") {
document.getElementById("realm").disabled=false;
document.getElementById("cookieSecretKey").disabled=true;
document.getElementById("cookieLifetime").disabled=true;
document.getElementById("cookieLifetimeMedium").disabled=true;
document.getElementById("includeIP").disabled=true;
document.getElementById("cookiePathOverride").disabled=true;
document.getElementById("phpCookiePathOverride").disabled=true;
document.getElementById("realmRequired").innerHTML="*";
document.getElementById("cookieSecretKeyRequired").innerHTML="";
document.getElementById("cookieLifetimeRequired").innerHTML="";
document.getElementById("includeIPRequired").innerHTML="";
}
else if (document.getElementById("sessionType").value == "cookie") {
document.getElementById("realm").disabled=true;
document.getElementById("cookieSecretKey").disabled=false;
document.getElementById("cookieLifetime").disabled=false;
document.getElementById("cookieLifetimeMedium").disabled=false;
document.getElementById("includeIP").disabled=false;
document.getElementById("cookiePathOverride").disabled=false;
document.getElementById("phpCookiePathOverride").disabled=true;
document.getElementById("realmRequired").innerHTML="";
document.getElementById("cookieSecretKeyRequired").innerHTML="*";
document.getElementById("cookieLifetimeRequired").innerHTML="*";
document.getElementById("includeIPRequired").innerHTML="*";
}
else if (document.getElementById("sessionType").value == "php") {
document.getElementById("realm").disabled=true;
document.getElementById("cookieSecretKey").disabled=true;
document.getElementById("cookieLifetime").disabled=true;
document.getElementById("cookieLifetimeMedium").disabled=true;
document.getElementById("includeIP").disabled=true;
document.getElementById("cookiePathOverride").disabled=true;
document.getElementById("phpCookiePathOverride").disabled=false;
document.getElementById("realmRequired").innerHTML="";
document.getElementById("cookieSecretKeyRequired").innerHTML="";
document.getElementById("cookieLifetimeRequired").innerHTML="";
document.getElementById("includeIPRequired").innerHTML="";
}
else if (document.getElementById("sessionType").value == "remote_user") {
document.getElementById("realm").disabled=true;
document.getElementById("cookieSecretKey").disabled=true;
document.getElementById("cookieLifetime").disabled=true;
document.getElementById("cookieLifetimeMedium").disabled=true;
document.getElementById("includeIP").disabled=true;
document.getElementById("cookiePathOverride").disabled=true;
document.getElementById("phpCookiePathOverride").disabled=true;
document.getElementById("logOutLink").disabled=false;
document.getElementById("realmRequired").innerHTML="";
document.getElementById("cookieSecretKeyRequired").innerHTML="";
document.getElementById("cookieLifetimeRequired").innerHTML="";
document.getElementById("includeIPRequired").innerHTML="";
document.getElementById("logOutLinkRequired").innerHTML="*";
}
else {
document.getElementById("realm").disabled=true;
document.getElementById("cookieSecretKey").disabled=true;
document.getElementById("cookieLifetime").disabled=true;
document.getElementById("cookieLifetimeMedium").disabled=true;
document.getElementById("includeIP").disabled=true;
document.getElementById("cookiePathOverride").disabled=true;
document.getElementById("phpCookiePathOverride").disabled=true;
document.getElementById("realmRequired").innerHTML="";
document.getElementById("cookieSecretKeyRequired").innerHTML="";
document.getElementById("cookieLifetimeRequired").innerHTML="";
document.getElementById("includeIPRequired").innerHTML="";
}
}

[mossj]

Twigged it

[contink]

Just thinking... if you'd provided the error message and/or context it probably would have helped


Also, just a thought but perhaps a little more efficient if you use this bit of code instead.

function session() {
mySessionType = document.getElementById("sessionType").value;
if (mySessionType == "http") {

... at the moment you're forcing it to run the getElementById function repeatedly..

[mossj]

How do you get javascript to output error codes?!? All i get is a lil icon at the bottom

Would of been so helpful.

Point noted about the "getElementbyID", will change.

[contink]

How do you get javascript to output error codes?!? All i get is a lil icon at the bottom

Would of been so helpful.

Point noted about the "getElementbyID", will change.

Ah.. in firefox there's the error console and firebug... very useful tools for debugging... I'm sure if you create another thread on JS debugging you'll be deluged with ideas and resources.

[CESIL]

If you double click on the lil icon you can get a slightly more detailed error message...should also give you the line number where the error is located...