Php function

[handoyo]

Hi all,i need help please..I got 2 php files,i'm intending to call a insert function from fns.inc.php to make a insert into myql database query..But it doesn't work..Here are the codes..Thanks a lot...

output_fns.php

function display_login_form()
{
$Error = array("email" => "","pwd" =>"","pwd1"=>"");
if(isset($_POST['submit']))
{
$email=mysql_real_escape_string($_POST['email']);
if(empty($email)){
$Error['email'] = "Email tidak boleh kosong";
}
else
if (!strchr($email, '@')) {
$Error['email'] = "Email yang anda masukkan tidak valid";
}  
$pwd1=mysql_real_escape_string($_POST['pwd1']);
if(empty($pwd1))
{
$Error['pwd1'] = "Password 1 tidak boleh kosong";
}
$pwd2=mysql_real_escape_string($_POST['pwd2']);
if(empty($pwd2))
{
$Error['pwd'] = "Password 2 tidak boleh kosong";
}
else
if($pwd1 != $pwd2)
{
$Error['pwd'] = "Password harus cocok";
}
$nama=mysql_real_escape_string($_POST['nama']);
$tmpt=mysql_real_escape_string($_POST['tempat_lahir']);
$tgl=mysql_real_escape_string($_POST['tgl']);
$bln=mysql_real_escape_string($_POST['bln']);
$thn=mysql_real_escape_string($_POST['thn']);
$tgl_lahir=$tgl.'-'.$bln.'-'.$thn;
$jekel=mysql_real_escape_string($_POST['jekel']);
$alamat=mysql_real_escape_string($_POST['alamat']);
$kota=mysql_real_escape_string($_POST['kota']);
$propinsi=mysql_real_escape_string($_POST['propinsi']);
if(empty($Error))
{
//this is the function that i want to call
insert($email,$pwd,$nama,$tgl_lahir,$jekel,$tmpt,$alamat,$kota,$propinsi);
}
}
else
{
$email="";
$pwd1="";
$pwd2="";
$nama="";
$tmpt="";
$tgl="";
$bln="";
$thn="";
$tgl_lahir=$tgl.'-'.$bln.'-'.$thn;
$jekel="";
$alamat="";
$kota="";
$propinsi="";
}
?>
<div id="stylized" class="myform">
  <form id="form1" name="form1" method="post" action="register.php">
    <fieldset>
    <legend >Data keanggotaan</legend>
    <br>
    <label>Email anda</label>
    <input type="text" name="email" id="email" value="<?php echo $email; ?>"/>
    <span class="error">&nbsp;<?php echo $Error['email']; ?></span>
    <div class="spacer"></div>
    <label>Password
        <span class="small">6-12 karakter</span>
    </label>
    <input type="password" name="pwd1" id="pwd1" ?>
    <span class="error">&nbsp;<?php echo $Error['pwd1']; ?></span>
    <div class="spacer"></div>
    <label>Ulangi Password
    </label>
    <input type="password" name="pwd2" id="pwd2" />
    <span class="error">&nbsp;<?php echo $Error['pwd']; ?></span>
    <div class="spacer"></div>
    </fieldset>
    <fieldset>
    <legend>Data pribadi</legend>
    <br>
    <h1>&nbsp;&nbsp; * Mohon diisi dengan data yang sebenarnya</h1>
    <div class="spacer"></div>
    <br>
    <label>Nama lengkap anda *
    <span class="small">Mohon nama asli anda</span>
    </label>
    <input type="text" name="nama" id="nama" value="<?php echo $nama; ?>"/>
    <div class="spacer"></div>
    <label>Tempat lahir anda *
    <span class="small"></span>
    </label>
    <input type="text" name="tempat_lahir" id="tempat_lahir"/>
    <div class="spacer"></div>
    <label for="tgl">Tanggal lahir *
    <span class="small">dd/mm/yyyy</span>
    </label>
    <select name="tgl" id="tgl">
        <option value="1" selected="selected">1</option>
        <option value="2">2</option>
        <option value="3">3</option>
        <option value="4">4</option>
        <option value="5">5</option>
        <option value="6">6</option>
        <option value="7">7</option>
        <option value="8">8</option>
        <option value="9">9</option>
        <option value="10">10</option>
        <option value="11">11</option>
        <option value="12">12</option>
        <option value="13">13</option>
        <option value="14">14</option>
        <option value="15">15</option>
        <option value="16">16</option>
        <option value="17">17</option>
        <option value="18">18</option>
        <option value="19">19</option>
        <option value="20">20</option>
        <option value="21">21</option>
        <option value="22">22</option>
        <option value="23">23</option>
        <option value="24">24</option>
        <option value="25">25</option>
        <option value="26">26</option>
        <option value="27">27</option>
        <option value="28">28</option>
        <option value="29">29</option>
        <option value="30">30</option>
        <option value="31">31</option>
      </select>
        <label for="bln"></label><select name="bln" id="bln">
        <option value="1" selected="selected">1</option>
        <option value="2">2</option>
        <option value="3">3</option>
        <option value="4">4</option>
        <option value="5">5</option>
        <option value="6">6</option>
        <option value="7">7</option>
        <option value="8">8</option>
        <option value="9">9</option>
        <option value="10">10</option>
        <option value="11">11</option>
        <option value="12">12</option>
        </select>
        <label for="thn"></label>
    <input type="text" name="thn" id="thn"/>
        <div class="spacer"></div>
        <label>Jenis Kelamin
    <span class="small">Jenis kelamin anda</span>
    </label>
        <select name="jekel">
     <option value="Pilih" selected="selected">Pilih salah satu... </option>
     <option value="pria" id="jekel">Pria</option>
     <option value="wanita" id="jekel">Wanita</option>
     
        </select>
        <div class="spacer"></div>
        <label>Alamat 
        <span class="small">Alamat lengkap anda</span>
        </label>
        <input type="text" name="alamat" id="alamat"/>
        <div class="spacer"></div>
        <label>Kota 
        <span class="small">Kota anda</span>
        </label>
        <input type="text" name="kota" id="kota"/>
        <div class="spacer"></div>
        <label>Propinsi 
        <span class="small">Propinsi anda</span>
        </label>
        <select name="propinsi">
        <option value="Pilih" selected="selected">Pilih salah satu....</option>
     <option>Nanggroe Aceh Darussalam</option>
    <option>Sumatera Utara</option>
    <option>Sumatera Barat</option>
    <option>Bengkulu</option>
    <option>Riau</option>
    <option>Kepulauan Riau</option>
    <option>Jambi</option>
    <option>Sumatera Selatan</option>
    <option>Lampung</option>
    <option>Kepulauan Bangka Belitung</option>
    <option>DKI Jakarta</option>
    <option>Jawa Barat</option>
    <option>Banten</option>
    <option>Jawa Tengah</option>
    <option>DI Yogyakarta</option>
    <option>Jawa Timur</option>
    <option>Kalimantan Barat</option>
    <option>Kalimantan Tengah</option>
    <option>Kalimantan Selatan</option>
    <option>Kalimantan Timur</option>
    <option>Bali</option>
    <option>Nusa Tenggara Barat</option>
    <option>Nusa Tenggara Timur</option>
    <option>Sulawesi Barat</option>
    <option>Sulawesi Utara</option>
    <option>Sulawesi Tengah</option>
    <option>Sulawesi Selatan</option>
    <option>Sulawesi Tenggara</option>
    <option>Gorontalo</option>
    <option>Maluku</option>
    <option>Maluku Utara</option>
    <option>Papua Barat</option>
    <option>Papua</option>
        </select>
    
        </fieldset>
    <br>
    <button type="submit" name="submit">Sign-up</button>
    
  </form>
</div> 

fns.inc.php

 <?php
function insert($email,$pwd,$nama,$tgl_lahir,$jekel,$tmpt,$alamat,$kota,$propinsi)
{
$tambahuser="INSERT INTO `users` (`email`,`password`,`nama`,`tempat_lahir`,
`tgl_lahir`,`jenis_kelamin`,`alamat`,`kota`,`propinsi`)
VALUES ('$email','$pwd','$nama','$tmpt','$tgl_lahir','$jekel','$alamat','$kota','$propinsi');";   
$exec=mysql_query($tambahuser);
if ($exec)
{
   header('location:thanks.php');
   return mysql_affected_rows();
}
else
{
    echo mysql_error();
}
}
?>  

[Pashers]

What error messages are you getting (if any).

Try displaying the contents of $tambahuser before or after
$exec=mysql_query($tambahuser);


$tambahuser="INSERT INTO users (email,password,nama,tempat_lahir,
tgl_lahir,jenis_kelamin,alamat,kota,propinsi)
VALUES ('".$email."','".$pwd."','".$nama."','".$tmpt."',' ".$tgl_lahir."','".$jekel."','".$alamat."','".$kot a."','".$propinsi."')";

Note you don't need the quotes for the table name and paramaters!

The string is concatinated for example:
'email@test.com', 'pass1234','...

Make sure your single quotes are inside the double quotes.
e.g.
" '_" . $myVar . "_' "
Remove the _, this is to show there is a single quote embedded with double quotes.

This is one issue i've noticed, you sure you're connecting to the database ok?!

[deanc]

dont forget that at some point the first file will need know where to find the functions.

you will need an include() or similar.


you may have done this but it is not in the listings supplied also the <?php was missing from the start assumed that it was chopped of in the paste

[handoyo]

I got no error ouput there,i've include the db connection file in the fns.inc.php..Suppose i do something wrong with calling the function?Thanks a lot...For the output_fns.php here are the full codes..

 <?php
 
include('fns.inc.php');
//buat header
function do_kepala($title){
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
<title><?php echo $title ?></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="include/style.css" type="text/css">
 
</head>
<body>
<?php
};
//buat body
function do_body()
{
login_form();
?>
<?php
};
function do_footer()
{
?>
    
</body>
</html>
<?php
};
function display_login_form()
{
$Error = array("email" => "","pwd" =>"","pwd1"=>"");
if(isset($_POST['submit']))
{
$email=mysql_real_escape_string($_POST['email']);
if(empty($email)){
$Error['email'] = "Email tidak boleh kosong";
}
else
if (!strchr($email, '@')) {
$Error['email'] = "Email yang anda masukkan tidak valid";
}  
$pwd1=mysql_real_escape_string($_POST['pwd1']);
if(empty($pwd1))
{
$Error['pwd1'] = "Password 1 tidak boleh kosong";
}
$pwd2=mysql_real_escape_string($_POST['pwd2']);
if(empty($pwd2))
{
$Error['pwd'] = "Password 2 tidak boleh kosong";
}
else
if($pwd1 != $pwd2)
{
$Error['pwd'] = "Password harus cocok";
}
$nama=mysql_real_escape_string($_POST['nama']);
$tmpt=mysql_real_escape_string($_POST['tempat_lahir']);
$tgl=mysql_real_escape_string($_POST['tgl']);
$bln=mysql_real_escape_string($_POST['bln']);
$thn=mysql_real_escape_string($_POST['thn']);
$tgl_lahir=$tgl.'-'.$bln.'-'.$thn;
$jekel=mysql_real_escape_string($_POST['jekel']);
$alamat=mysql_real_escape_string($_POST['alamat']);
$kota=mysql_real_escape_string($_POST['kota']);
$propinsi=mysql_real_escape_string($_POST['propinsi']);
if(empty($Error))
{
insert($email,$pwd,$nama,$tgl_lahir,$jekel,$tmpt,$alamat,$kota,$propinsi);
}
}
else
{
$email="";
$pwd1="";
$pwd2="";
$nama="";
$tmpt="";
$tgl="";
$bln="";
$thn="";
$tgl_lahir=$tgl.'-'.$bln.'-'.$thn;
$jekel="";
$alamat="";
$kota="";
$propinsi="";
}
?>
<div id="stylized" class="myform">
  <form id="form1" name="form1" method="post" action="register.php">
    <fieldset>
    <legend >Data keanggotaan</legend>
    <br>
    <label>Email anda</label>
    <input type="text" name="email" id="email" value="<?php echo $email; ?>"/>
    <span class="error">&nbsp;<?php echo $Error['email']; ?></span>
    <div class="spacer"></div>
    <label>Password
        <span class="small">6-12 karakter</span>
    </label>
    <input type="password" name="pwd1" id="pwd1" ?>
    <span class="error">&nbsp;<?php echo $Error['pwd1']; ?></span>
    <div class="spacer"></div>
    <label>Ulangi Password
    </label>
    <input type="password" name="pwd2" id="pwd2" />
    <span class="error">&nbsp;<?php echo $Error['pwd']; ?></span>
    <div class="spacer"></div>
    </fieldset>
    <fieldset>
    <legend>Data pribadi</legend>
    <br>
    <h1>&nbsp;&nbsp; * Mohon diisi dengan data yang sebenarnya</h1>
    <div class="spacer"></div>
    <br>
    <label>Nama lengkap anda *
    <span class="small">Mohon nama asli anda</span>
    </label>
    <input type="text" name="nama" id="nama" value="<?php echo $nama; ?>"/>
    <div class="spacer"></div>
    <label>Tempat lahir anda *
    <span class="small"></span>
    </label>
    <input type="text" name="tempat_lahir" id="tempat_lahir"/>
    <div class="spacer"></div>
    <label for="tgl">Tanggal lahir *
    <span class="small">dd/mm/yyyy</span>
    </label>
    <select name="tgl" id="tgl">
        <option value="1" selected="selected">1</option>
        <option value="2">2</option>
        <option value="3">3</option>
        <option value="4">4</option>
        <option value="5">5</option>
        <option value="6">6</option>
        <option value="7">7</option>
        <option value="8">8</option>
        <option value="9">9</option>
        <option value="10">10</option>
        <option value="11">11</option>
        <option value="12">12</option>
        <option value="13">13</option>
        <option value="14">14</option>
        <option value="15">15</option>
        <option value="16">16</option>
        <option value="17">17</option>
        <option value="18">18</option>
        <option value="19">19</option>
        <option value="20">20</option>
        <option value="21">21</option>
        <option value="22">22</option>
        <option value="23">23</option>
        <option value="24">24</option>
        <option value="25">25</option>
        <option value="26">26</option>
        <option value="27">27</option>
        <option value="28">28</option>
        <option value="29">29</option>
        <option value="30">30</option>
        <option value="31">31</option>
      </select>
        <label for="bln"></label><select name="bln" id="bln">
        <option value="1" selected="selected">1</option>
        <option value="2">2</option>
        <option value="3">3</option>
        <option value="4">4</option>
        <option value="5">5</option>
        <option value="6">6</option>
        <option value="7">7</option>
        <option value="8">8</option>
        <option value="9">9</option>
        <option value="10">10</option>
        <option value="11">11</option>
        <option value="12">12</option>
        </select>
        <label for="thn"></label>
    <input type="text" name="thn" id="thn"/>
        <div class="spacer"></div>
        <label>Jenis Kelamin
    <span class="small">Jenis kelamin anda</span>
    </label>
        <select name="jekel">
     <option value="Pilih" selected="selected">Pilih salah satu... </option>
     <option value="pria" id="jekel">Pria</option>
     <option value="wanita" id="jekel">Wanita</option>
     
        </select>
        <div class="spacer"></div>
        <label>Alamat 
        <span class="small">Alamat lengkap anda</span>
        </label>
        <input type="text" name="alamat" id="alamat"/>
        <div class="spacer"></div>
        <label>Kota 
        <span class="small">Kota anda</span>
        </label>
        <input type="text" name="kota" id="kota"/>
        <div class="spacer"></div>
        <label>Propinsi 
        <span class="small">Propinsi anda</span>
        </label>
        <select name="propinsi">
        <option value="Pilih" selected="selected">Pilih salah satu....</option>
     <option>Nanggroe Aceh Darussalam</option>
    <option>Sumatera Utara</option>
    <option>Sumatera Barat</option>
    <option>Bengkulu</option>
    <option>Riau</option>
    <option>Kepulauan Riau</option>
    <option>Jambi</option>
    <option>Sumatera Selatan</option>
    <option>Lampung</option>
    <option>Kepulauan Bangka Belitung</option>
    <option>DKI Jakarta</option>
    <option>Jawa Barat</option>
    <option>Banten</option>
    <option>Jawa Tengah</option>
    <option>DI Yogyakarta</option>
    <option>Jawa Timur</option>
    <option>Kalimantan Barat</option>
    <option>Kalimantan Tengah</option>
    <option>Kalimantan Selatan</option>
    <option>Kalimantan Timur</option>
    <option>Bali</option>
    <option>Nusa Tenggara Barat</option>
    <option>Nusa Tenggara Timur</option>
    <option>Sulawesi Barat</option>
    <option>Sulawesi Utara</option>
    <option>Sulawesi Tengah</option>
    <option>Sulawesi Selatan</option>
    <option>Sulawesi Tenggara</option>
    <option>Gorontalo</option>
    <option>Maluku</option>
    <option>Maluku Utara</option>
    <option>Papua Barat</option>
    <option>Papua</option>
        </select>
    
        </fieldset>
    <br>
    <button type="submit" name="submit">Sign-up</button>
    
  </form>
</div>
 
<?php
};
function doError( $field )
{
  if( isset($errors[$field]) ) {
    echo '<span class="error">'.$errors[$field].'</span>';
}
?>
<?php
};
function login_form()
{
?>
<div id="styled" class="loginform">
<form id="form1" name="form1" method="post" action="auth.php">
<label>Email anda </label>
        <input type="text" name="email" id="email"/>
        <div class="spacer"></div>
        <label>Password 
        <span class="small"></span>
        </label>
        <input type="password" name="pwd" id="pwd"/>
        <div class="spacer"></div>
    <button type="submit" name="submit">Log In</button>
</form>
<a class="nav" href="register.php">Register</a>
<br>
</div>
<?php
};
?>  

[PaulBM]

Assuming no header information has been sent when the code hits...

header('location:thanks.php');
return mysql_affected_rows();

the page will redirect to thanks.php and will never return the affected rows.

To track the bug, change that to display the mysql return value and string too.

As others have said what errors do you get back from mySQL?

I always put single quotes around the values for string fields and leave them off for numeric fields. Not sure if it's vital, but it helps me spot numeric and string fields.

[handoyo]

I got no errors from mysql,it just the textfield values are still remain..Thanks...

[PaulBM]

Hmmm, so no errors when connecting to the database, no errors when INSERTing the data, and yet nothing in the database tables when you check them via phpmyadmin or similar program?

[handoyo]

Yes,should i send you the files perhaps??I've checked using phpmyadmin..No data's updated...Thanks..

[handoyo]

Yes,i upload the files here.

[Pashers]

Could you try:

 if(empty($Error))
{
echo "<B>TESTING TESTING 123</B>"
insert($email,$pwd,$nama,$tgl_lahir,$jekel,$tmpt,$alamat,$kota,$propinsi);
} 
  

Line 72 in the fns.inc.php

Does the TESTING TESTING 123 display on the page?

[handoyo]

Hi Pashers,i've tried it.No,it doesn't show up..Maybe there are something wrong with my code perhaps??Thanks...

[cullingsh]

It's been a while since i looked at PHP, but the IF statement in the fns.inc.php doesnt have a condition with it, ie if($exec=whatever) rather than just if($exec)


Should there not be more to it?

[Pashers]

Sorry I have to go off now. However, try continuing with the following:

 function display_login_form()
{
echo "ENTER LOGIN"
$Error = array("email" => "","pwd" =>"","pwd1"=>"");
if(isset($_POST['submit']))
{
 echo "ENTER SUBMIT"
 $email=mysql_real_escape_string($_POST['email']);
 if(empty($email)){
  echo "ENTER EMPTY EMAIL"
  $Error['email'] = "Email tidak boleh kosong";
 }
 else {
  if (!strchr($email, '@')) {
   echo "ENTER EMAIL NO @"
   $Error['email'] = "Email yang anda masukkan tidak valid";
  } 
  

Note the echo, place them where ever you can to try and see which directions it goes. This may/may not help. But should help show the issues!

[handoyo]

Hi cullingsh,the if($exec) doesn't get any problem if i put it in the output_fns.php.Maybe i have missed some statements there..Thanks..

[handoyo]

The echo works Pashers..But still can't get it working..