FOR /F Loop batch help...

[ben604]

I'm trying to import our machines from Fog into our new AD using this script I found on the interwebs:

for /f "tokens=1,2 delims= " %a in (fogreport.csv) do wdsutil /Set-Device /Device:%a /ID:%b

It's reading the CSV but combining both the %a and %b columns into the /Device: field, giving an error that the input for /ID: is incorrect...

Any ideas what I'm doing wrong? I'm using a CSV on Windows 7

Thanks in advance,
Ben

[X-13]

I would check what is being picked up as %b.

It may as simple as it's picking up the wrong thing.


Also, if it's a CSV... why isn't the delimiter a comma?

[ben604]

I would check what is being picked up as %b.

It may as simple as it's picking up the wrong thing.


Also, if it's a CSV... why isn't the delimiter a comma?

The output is wdsutil /Set-Device /Device:moodle,00:11:22:33:44:55 /ID: (blank)

Where do I define the delimiter, sorry not my strong suite, command line stuff...!

[Steve21]

The output is wdsutil /Set-Device /Device:moodle,00:11:22:33:44:55 /ID: (blank)

Where do I define the delimiter, sorry not my strong suite, command line stuff...!

Not sure if it'll work as I didn't test it, but seesm you have same problem someone did yesterday

for /F "tokens=1,2 delims=," %%1 in (ahosts.txt) do echo %%1 %%2

Note double %%

Steve

[X-13]

The output is wdsutil /Set-Device /Device:moodle,00:11:22:33:44:55 /ID: (blank)

Where do I define the delimiter, sorry not my strong suite, command line stuff...!

delims=

I think it should be delims=, [with 100% extra comma, free!]

If /ID: is blank, I would check the CSV.

From what is being used in /Device: it looks like it's using both.


If I'm understanding it correctly, it should be /ID:00:11:22:33:44:55.

Not sure if it'll work as I didn't test it, but seesm you have same problem someone did yesterday

for /F "tokens=1,2 delims=," %%1 in (ahosts.txt) do echo %%1 %%2

Note double %%

Steve

Double in a batch file, single in command line.

It entirely depends on how it's being used.

[plexer]

for /f "tokens=1,2 delims=, " %%a in (fogreport.csv) do wdsutil /Set-Device /Device:%%a /ID:%%b

Should do it?

Ben

[plexer]

When using for in a batch files you need to use a double % if runnign it direct from a command prompt you use a single %

Ben

[ben604]

Thanks guys, tried all those variations with no results...

for /f "tokens=1,2 delims=, " %a in (fogreport.csv) do wdsutil /Set-Device /Device:%a /ID:%b

gives

wdsutil /Set-Device /Device:moodle /ID:%b

[Steve21]

Thanks guys, tried all those variations with no results...

for /f "tokens=1,2 delims=, " %a in (fogreport.csv) do wdsutil /Set-Device /Device:%a /ID:%b

gives

wdsutil /Set-Device /Device:moodle /ID:%b

Because you ignored all of us
Double %% !

Steve

[X-13]

Because you ignored all of us
Double %% !

Steve

%a is setting fine, so that's not the problem.

[ben604]

Sorry Steve, I wasn't ignoring you!

%%a gave an error, %a seems to be getting at least half the job done!

[plexer]

In a batch file:

echo off
for /f "tokens=1,2 delims=, " %%a in (c:\scripts\input.csv) do echo wdsutil /Set-Device /Device:%%a /ID:%%b

Input file:
moodle,00:00:00:00:00
test1,01:00:00:00:00
test2,02:00:00:00:00

Emulates the output that you are expecting for me

Ben

[plexer]

Can you post some of your fogreport.csv???

Ben

[plexer]

%a is setting fine, so that's not the problem.

It will do if run from the command line but in a batch file it needs to be %%

If a% is setting ok from the command line there must be an errorr in the input file.

Ben

[X-13]

In a batch file:

echo off
for /f "tokens=1,2 delims=, " %%a in (c:\scripts\input.csv) do echo wdsutil /Set-Device /Device:%%a /ID:%%b

Input file:
moodle,00:00:00:00:00
test1,01:00:00:00:00
test2,02:00:00:00:00

Emulates the output that you are expecting for me

Ben

Strangly, it isn't working properly for me.

All it's doing it parsing the file path...