New logonscript not working

[richard_s]

I'm in the process of writing a new logon script to replace several batch files but I'm having problems when it comes to running the script as nothing happens, no drives are mapped and no printer connections are created. I am basically a scripting noobie and could do with some help on this.

On Error Resume Next

'===TESTING ONLY===============================
Set oShell = CreateObject("WScript.Shell")

Set wshNetwork = CreateObject("WScript.Network")
Set objNetwork = CreateObject("WScript.Network")
Set oPrinters = objNetwork.EnumPrinterConnections
Set ADSysInfo = CreateObject("ADSystemInfo")
Set CurrentUser = GetObject("LDAP://" & ADSysInfo.UserName)
strGroups = LCase(CurrentUser.DistinguishedName)
Set CurrentComp = GetObject("LDAP://" & ADSysInfo.Computername)
OrgUnit = Lcase(CurrentComp.distinguishedname)

'====================================
' User Grouping constants
'====================================
Const DA       = "ou=Admin"
Const TEACHERS = "ou=Staff"
Const PUPILS   = "ou=Pupils"

'=========================================
'               PRINTERS                 =
'=========================================
Set WshNetwork = WScript.CreateObject("WScript.Network")
PrinterPath = "\\savioursrv\HPLASERJETCOL3000"
WshNetwork.AddWindowsPrinterConnection PrinterPath
WshNetwork.SetDefaultPrinter

var WshNetwork = WScript.CreateObject("WScript.Network");
var PrinterPath = "\\\\savioursrv\\HPLASERJETCOL3000";
WshNetwork.AddWindowsPrinterConnection(PrinterPath);
WshNetwork.SetDefaultPrinter "ict01\HPLASERJETCOL3000";


'========================================
'Domain Admins' drive shares
'========================================
If InStr(strGroups, DA) Then
	wshNetwork.MapNetworkDrive "u:", "\\savioursrv\User$"
	wshNetwork.MapNetworkDrive "p:", "\\savioursrv\Public$"
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"


'========================================
'Teachers drive shares
'========================================
ElseIf InStr(strGroups, TEACHERS) Then
	wshNetwork.MapNetworkDrive "u:", "\\savioursrv\User$\Pupils"
	wshNetwork.MapNetworkDrive "p:", "\\savioursrv\Public$"
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"


'========================================
'   Pupils Year 3 Drive Maps
'========================================
Elseif InStr(lcase(CurrentUser.Name),"3") Then
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources\Year 3"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"


'========================================
'   Pupils Year 4 Drive Maps
'========================================
Elseif InStr(lcase(CurrentUser.Name),"4") Then
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources\Year 4"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"


'========================================
'   Pupils Year 5 Drive Maps
'========================================
'Elseif InStr(lcase(CurrentUser.Name),"5") Then
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources\Year 5"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"

'========================================
'   Pupils Year 6 Drive Maps
'========================================
'Elseif InStr(lcase(CurrentUser.Name),"6") Then
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources\Year 6"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"

End If

[CyberNerd]

add a marker to see where it fails or if the script is getting run

WScript.Echo(" some text!")

[TheScarfedOne]

I'll second that. Also - get it to echo any variables to make sure it is returning what you think it is. Another hint, I use Notepad++ for writing our VBS scripts - as it will show the formatting for you.

I will also be publishing a load of scripts as a "project", just need to clear it with James when I finally get chance to chat to him again since LG Conference.

[richard_s]

add a marker to see where it fails or if the script is getting run

WScript.Echo(" some text!")

I have just added this to the script and when I run it nothing happens.

[TheScarfedOne]

Use the code at various points through the code (with the echo text telling you where in the code you are)... this will show where its getting to before falling over.

[ChrisH]

Comment out

On Error Resume Next

It will then give you an error.

[ChrisH]

Also this are doesn't look right

var WshNetwork = WScript.CreateObject("WScript.Network");
var PrinterPath = "\\\\savioursrv\\HPLASERJETCOL3000";
WshNetwork.AddWindowsPrinterConnection(PrinterPath);
WshNetwork.SetDefaultPrinter "ict01\HPLASERJETCOL3000";

Specifically the amount of back slashes and in some cases lack of eg on the SetDefaultPrinter. You do have to use extra back slashes when doing reg stuff sometimes but I dont think they are needed here.

I am guessing it should look like this

var WshNetwork = WScript.CreateObject("WScript.Network");
var PrinterPath = "\\savioursrv\HPLASERJETCOL3000";
WshNetwork.AddWindowsPrinterConnection(PrinterPath);
WshNetwork.SetDefaultPrinter "\\ict01\HPLASERJETCOL3000";

[TheScarfedOne]

Also... I would use

Dim StrWhatever

StrWhatever = Whatever

Rather than using var and declaring value in the same place.

[richard_s]

The problem seems to lie with the group specfic shares as I changed the script so that

wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"

mapping was done separtley to the others and it is the only share that is mapped at logon.

[ChrisH]

So you need to check if the group check is working then?

Try this

If InStr(strGroups, DA) Then
Wscipt.echo "User has passed the admins check"
	wshNetwork.MapNetworkDrive "u:", "\\savioursrv\User$"
	wshNetwork.MapNetworkDrive "p:", "\\savioursrv\Public$"
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"


'========================================
'Teachers drive shares
'========================================
ElseIf InStr(strGroups, TEACHERS) Then
Wscript.Echo "This user is a teacher"
	wshNetwork.MapNetworkDrive "u:", "\\savioursrv\User$\Pupils"
	wshNetwork.MapNetworkDrive "p:", "\\savioursrv\Public$"
	wshNetwork.MapNetworkDrive "t:", "\\savioursrv\SharedResources"
	wshNetwork.MapNetworkDrive "v:", "\\savioursrv\Photographs"

Try an admin and a teacher account. If you dont get a popup then your group checking code isn't working.

[altecsole]

Where are you getting the value of strGroups from? Do a wscript.echo strGroups to check the value.

Also, it's good practise to add Option Explicit to the top of your script. That forces you to declare all varables before you use them.