PHP form

[Edu-IT]

Have a couple of issues with this form and wondering if anyone can help?

Here's the code I am using: http://pastebin.com/bEkihqgY



The problems:

• If you submit the empty form, the error validation returns back "Please fill in all the required fields and submit again." twice. How can I get it to say the name of the fields instead?
• The profanity filter doesn't work on the name field?

[CESIL]

Instead of outputting the error message each time an empty field is found you need to build a variable containing the names of the empty fields.

Then after you have looped through POST values test if the variable contains any value and then output the error message including the list of empty fields.

Another approach I have used in the past is to output a standard message and use css to highlight the empty fields by filling them with red or changing the border...

[CESIL]

Something like this would also do it

if (!isset($_POST[$field]) || empty($_POST[$field]))
     $error_msg .= "Please fill in the $field field and submit again.\r\n";
}

BTW I like the 'orgasim' entry in your profanity list...shows how good sex-ed is doesn't it

[Edu-IT]

Not me who wrote the code. ;-)

I'll adjust that, thanks. Any ideas why profanity doesn't cover the name field?

[Edu-IT]

Any ideas how to get the form to entered retain data on error?

[Hightower]

Any ideas how to get the form to entered retain data on error?

<input type="text" name="email" value="<?php if (isset($_POST['email']) && !empty($_POST['email'])) echo $_POST['email']; ?>" /> 

[CESIL]

<input type="text" name="email" value="<?php if (isset($_POST['email']) && !empty($_POST['email'])) echo $_POST['username']; ?>" /> 

shouldn't that last echo be outputting 'email'?

[Hightower]

shouldn't that last echo be outputting 'email'?

It's 3 o'clock on Friday on the first week back from a 2 week break.....

[Edu-IT]

I assume there's one of those for each field?

[Hightower]

I assume there's one of those for each field?

Yep, just stick the PHP script in the value for each one and change the $_POST['email'] to whatever

[Edu-IT]

Awesome, thanks! :-)

[Edu-IT]

Where am I going wrong here? Certain fields don't line up.

<style type="text/css">
/*Contact form*/
label {
width:4em;
float:left;
text-align:right;
margin-right:1.5em;
display:block
}
.submit input {
margin-left:4.5em;
}
input.text {
border:1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=232a15]#232a15[/URL]
margin:2px;
border:1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=A8A8A8]#A8A8A8[/URL]
font-family:Verdana,Arial,Helvetica,sans-serif;
}
textarea {
border: 1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=232a15]#232a15[/URL]
margin: 2px;
border:1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=A8A8A8]#A8A8A8[/URL]
font-family:Verdana,Arial,Helvetica,sans-serif;
}
fieldset {
border:1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=232a15]#232a15[/URL]
padding: 4px;
border:1px solid [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=A8A8A8]#A8A8A8[/URL]
}
p.error, p.success {
   font-weight: bold;
   padding: 10px;
   border: 1px solid;
  }
  p.error {
   background: [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=ffc0c0]#ffc0c0[/URL]
   color: [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=900]#900[/URL]
  }
  p.success {
   background: [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=b3ff69]#b3ff69[/URL]
   color: [URL=http://www.edugeek.net/misc.php?do=dbtech_usertag_hash&hash=4fa000]#4fa000[/URL]
  }
</style>
<form action="<?php echo basename(__FILE__); ?>" method="post">
<noscript>
  <p><input type="hidden" name="nojs" id="nojs" /></p>
</noscript>
     <fieldset>
     <div>
     <label for="name">Name</label>
     <input type="text" class="text" name="name" id="name" size="30" value="<?php if (isset($_POST['name']) && !empty($_POST['name'])) echo $_POST['name']; ?>" />
    </div>
     <div>
     <label for="pupilsname">Pupils Name (if different)</label>
     <input type="text" class="text" name="pupilsname" id="pupilsname" size="30" value="<?php if (isset($_POST['pupilsname']) && !empty($_POST['pupilsname'])) echo $_POST['pupilsname']; ?>" />
    </div>
     <div>
     <label for="tutorgroup">Tutor group</label>
     <input type="text" class="text" name="tutorgroup" id="tutorgroup" size="30" value="<?php if (isset($_POST['tutorgroup']) && !empty($_POST['tutorgroup'])) echo $_POST['tutorgroup']; ?>" />
    </div>
    <div>
     <label for="pupilssportactivity">Pupils sport/activity</label>
     <input type="text" class="text" name="pupilssportactivity" id="pupilssportactivity" size="30" value="<?php if (isset($_POST['pupilssportactivity']) && !empty($_POST['pupilssportactivity'])) echo $_POST['pupilssportactivity']; ?>" />
    </div>
    <div>
     <label for="pupilsachievement">Pupils achievement</label>
     <textarea rows="6" cols="40" name="pupilsachievement" id="pupilsachievement" value="<?php if (isset($_POST['pupilsachievement']) && !empty($_POST['pupilsachievement'])) echo $_POST['pupilsachievement']; ?>" /></textarea>
    </div>
     <div>
     <label for="email">E-mail</label>
     <input type="text" class="text" name="email" id="email" size="30" value="" />
    </div>
    <div class="submit">
     <input type="submit" name="submit" id="submit" value="Submit" />
    </div>
    </fieldset>
   </form>

Tutor group, pupils sport, pupils achievement all display out of line.

[Edu-IT]

Also I notice that on submit, the fields still retain data. Can this be cleared on successful submit?

And finally, how do I get the text area to retain entered data on error?

[Steve21]

Simple answer to first bit :P

Your length of the name is too long. Change "name if different" etc, to "name" and it'll realign, as it's pushing it onto new line. (or incease size of column)

Steve

[Edu-IT]

Simple answer to first bit :P

Your length of the name is too long. Change "name if different" etc, to "name" and it'll realign, as it's pushing it onto new line. (or incease size of column)

Steve

That's not it unfortunately.

Edit: Another thing I just noticed, when a field is not submitted, is it possible to just have the 'please complete all fields' messages displayed just once?